Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Un)escape URLs when reading/writing <img src=> attributes #2711

Merged
merged 10 commits into from
Aug 2, 2024
Merged

(Un)escape URLs when reading/writing <img src=> attributes #2711

merged 10 commits into from
Aug 2, 2024

Conversation

HenningLorenzen-ext-bayer
Copy link
Contributor

@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer commented Jul 12, 2024 •
edited
Loading

Fixes #2705

  • fix building on R 4.0.0 (not applicable with {xml2} functions)
  • replace utils::URLdecode() and utils::URLencode()

@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer marked this pull request as ready for review July 12, 2024 11:57
hadley
hadley reviewed Jul 12, 2024
View reviewed changes
R/tweak-page.R Outdated Show resolved Hide resolved
@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer changed the title Use URLdecode() and URLencode() when reading/writing <img src=> attributes (Un)escape URLs when reading/writing <img src=> attributes Jul 12, 2024
hadley
hadley reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this!

R/check-built.R Show resolved Hide resolved
R/pkgdown-package.R Outdated Show resolved Hide resolved
tests/testthat/test-build-article.R Outdated Show resolved Hide resolved
HenningLorenzen-ext-bayer added a commit to HenningLorenzen-ext-bayer/pkgdown that referenced this pull request Jul 16, 2024
@HenningLorenzen-ext-bayer
revert unnecessary changes
b4e1012 
addresses r-lib#2711 (comment)
@hadley hadley merged commit 502c3e2 into r-lib:main Aug 2, 2024
15 checks passed
@hadley
Copy link
Member

hadley commented Aug 2, 2024

@HenningLorenzen-ext-bayer thanks!

@HenningLorenzen-ext-bayer HenningLorenzen-ext-bayer deleted the fix/2705-img-src branch August 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build_article() gets confused with percent-encoding in <img> src path
2 participants
@HenningLorenzen-ext-bayer @hadley