Add guildId to rssFeeds collection schema #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mushroom-disaster
requested changes
Aug 22, 2022
|
Review should be addressed now, don't mind me taking 2 months to change three lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the guild where RSS feeds were created and filters by that guild (or, in DMs, the ID of the channel) when listing and deleting feeds. This fixes a bug where feeds would be exposed across servers, which we never encountered because nobody else uses this bot.
This will require manual migration of existing feeds after merging - for each existing feed, fetch the feed's channel and put its guild ID back into the object.