Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More HDAWG improvements #567

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

More HDAWG improvements #567

wants to merge 4 commits into from

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Mar 23, 2021 •
edited
Loading

  • Cleaner initialization and default settigs control.
  • Interface to set marker sources

TODO:

  • test with physical device

@terrorfisch terrorfisch requested a review from thangleiter March 23, 2021 14:54
@coveralls
Copy link

coveralls commented Mar 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 2283

  • 11 of 28 (39.29%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 80.058%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/awgs/zihdawg.py 11 28 39.29%
Files with Coverage Reduction New Missed Lines %
qupulse/hardware/awgs/zihdawg.py 1 41.33%
Totals Coverage Status
Change from base Build 2276: -0.1%
Covered Lines: 7163
Relevant Lines: 8761
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thangleiter thangleiter thangleiter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrorfisch @coveralls @thangleiter