Update GRDB.swift to fix an Xcode 16.0 Beta issue. #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is fixed with this PR (groue/GRDB.swift#1589), I am going to update the version to latest of GRDB released yesterday which is 6.29.2 ان شاء اللہ تَعَالٰی Closes quran#652
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 40.92% 39.68% -1.25%
==========================================
Files 525 526 +1
Lines 20880 19441 -1439
==========================================
- Hits 8546 7715 -831
+ Misses 12334 11726 -608 ☔ View full report in Codecov by Sentry. |
mohamede1945
approved these changes
Aug 25, 2024
takasurazeem
added a commit
to takasurazeem/quran-ios
that referenced
this pull request
Aug 25, 2024
Missed one place to update the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is fixed with this PR (groue/GRDB.swift#1589), I am going to update the version to latest of GRDB released yesterday which is 6.29.2 ان شاء اللہ تَعَالٰی
Closes #652