-
Notifications
You must be signed in to change notification settings - Fork 447
creating pytest to quokkaCMS #667
base: master
Are you sure you want to change the base?
Conversation
#fixing pep8 errors 323e196 (.venv) [marcosptf@localhost quokka]$ make test |
from wtforms.widgets import TextArea, TextInput | ||
from quokka.core.content.views import render_template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing pep8 import
category_slug = ( | ||
data.get('category_slug') or | ||
slugify_category(data.get('category') or '') | ||
data_category_slug or data_slugify_category | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing pep8 error:
W504 line break after binary operator
@@ -267,8 +270,7 @@ def render_rss(self, content_type, templates, **context): | |||
author=str(content.author), | |||
categories=[str(content.tags)], | |||
guid=hashlib.sha1( | |||
content.title.encode('utf-8') + | |||
content.url.encode('utf-8') | |||
content_title + content_url | |||
).hexdigest(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing pep8 error:
W504 line break after binary operator
self.get_tags() + | ||
self.get_authors() + | ||
self.get_articles_and_pages() | ||
index + cat + tags + authors + articles | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing pep8 error:
W504 line break after binary operator
@laerteallan fixes done => 1a1c4f5 |
Congrats on the job.. |
Hello @marcosptf! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-06-02 13:56:18 UTC |
im updating this branch with master and make test command has broken, im fixing it: 2.12s$ make test |
pep8 from Travis issues fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a lot of test to the project .. :)
I just believe it is good to make a git squash
to gather all commits
before sending to the master
This pr is to create pytest to quokkaCMS, this task is done, all questions and comments answer done, this pr is enable to merge and travis-ci is okey :-)
Att,
@marcosptf