Skip to content

Commit

Permalink
Build: Update to ESLint 8 and Semistandard 17
Browse files Browse the repository at this point in the history
In 9c3ae1a we updated to the latest supported versions for Node 10.
This commit updates to the latest supported for Node 18.

ESLint 9 requires a specific Node 18 release, and so can't be safely
selected without warnings from `ncu --enginesNode`. It requires either
ignoring that warning, or raising production requirements in package.json
to satisfy an internal dev dependency issue which is needlessly
inconveniences downstream users.
  • Loading branch information
Krinkle committed May 30, 2024
1 parent 335b040 commit fcf4d79
Show file tree
Hide file tree
Showing 10 changed files with 927 additions and 963 deletions.
3 changes: 2 additions & 1 deletion .eslintrc.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ const config = Object.assign(standard, {
semi: ['error', 'always'],
'no-extra-semi': 'error',
// disablements
'n/no-callback-literal': 'off',
'no-lone-blocks': 'off',
'node/no-callback-literal': 'off',
'object-shorthand': 'off',
'prefer-const': 'off',
'prefer-promise-reject-errors': 'off',
// extra
Expand Down
9 changes: 6 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"prefer-regex-literals": "off",
"qunit/literal-compare-order": "off",
"qunit/no-arrow-tests": "off",
"qunit/no-assert-equal": "off",
"qunit/no-assert-equal-boolean": "off",
"qunit/no-assert-logical-expression": "off",
"qunit/no-only": "off",
Expand All @@ -87,7 +88,7 @@
"excludedFiles": [
"build/coverage-bridge.js"
],
"extends": [".eslintrc.base.js", "plugin:node/recommended"],
"extends": [".eslintrc.base.js", "plugin:n/recommended"],
"parserOptions": {
"ecmaVersion": 2020,
"sourceType": "script"
Expand All @@ -99,8 +100,9 @@
"compat/compat": "off",
"no-console": "off",
"no-process-exit": "off",
"node/no-missing-require": "off",
"node/no-unpublished-require": "off"
"n/no-process-exit": "off",
"n/no-missing-require": "off",
"n/no-unpublished-require": "off"
}
},
// Misc overrides
Expand Down Expand Up @@ -208,6 +210,7 @@
"no-unused-expressions": "off",
"no-unused-vars": "off",
"no-var": "off",
"object-shorthand": "off",
"strict": "off"
}
},
Expand Down
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@
*.tap.txt eol=lf
*.json eol=lf
*.html eol=lf

/package-lock.json binary
Loading

0 comments on commit fcf4d79

Please sign in to comment.