Build: Enable and fix 'strict' via ESLint for Node.js files

Thanks to @mgol for raising this at
#1798.

.eslintrc.json

@@ -81,7 +81,7 @@
     {
       "files": [
         "bin/**",
-        "build/**",
+        "build/**/*.js",
         "src/cli/**",
         "Gruntfile.js",
         "rollup.config.js"
@@ -99,6 +99,7 @@
         "node": true
       },
       "rules": {
+        "strict": "error",
         "compat/compat": "off",
         "no-console": "off",
         "no-process-exit": "off",

Gruntfile.js

@@ -1,4 +1,5 @@
 /* eslint-env node */
+'use strict';
 
 const fs = require('fs');
 const path = require('path');

build/dev.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const http = require('http');
 const path = require('path');

build/dist-replace.js

@@ -5,6 +5,7 @@
 // If a date or timestamp is used, then honour SOURCE_DATE_EPOCH
 // and update RELEASE.md as needed.
 // <https://reproducible-builds.org/docs/source-date-epoch/>.
+'use strict';
 
 let distVersion = require('../package.json').version;
 

build/npm-search.js

@@ -1,27 +1,20 @@
+'use strict';
+
+const NPM_REGISTRY_URL = 'https://registry.npmjs.org/';
+
 /**
- * npm-search.js is based on npm-keyword v6.1.0 by @sindresorhus,
+ * This is based on npm-keyword v6.1.0 by @sindresorhus,
  * but simplified to not have 32 needless dependencies.
  *
  * - <https://github.com/sindresorhus/npm-keyword/tree/v6.1.0>
  * - <https://snyk.io/test/npm/npm-keyword/6.1.0?tab=dependencies>
+ *
+ * @param {string} keyword
+ * @return {Object[]} List of package objects
  */
-'use strict';
-const https = require('https');
-const registryUrl = 'https://registry.npmjs.org/';
-
-function fetch (url) {
-  return new Promise((resolve, reject) => {
-    const req = https.get(url, (resp) => {
-      let data = '';
-      resp.on('data', (chunk) => {
-        data += chunk;
-      });
-      resp.on('end', () => {
-        resolve(data);
-      });
-    });
-    req.on('error', reject);
-  });
+async function keyword (keyword) {
+  const { objects } = await search('keywords:' + keyword, { size: 250 });
+  return objects.map(element => element.package);
 }
 
 async function search (phrase, options) {
@@ -32,17 +25,9 @@ async function search (phrase, options) {
   }
 
   phrase = encodeURIComponent(phrase).replace('%2C', '+');
-  const url = `${registryUrl}-/v1/search?text=${phrase}&size=${options.size}`;
-  return JSON.parse(await fetch(url));
-}
-
-/**
- * @param {string} keyword
- * @return {Object[]} List of package objects
- */
-async function keyword (keyword) {
-  const { objects } = await search('keywords:' + keyword, { size: 250 });
-  return objects.map(element => element.package);
+  const url = `${NPM_REGISTRY_URL}-/v1/search?text=${phrase}&size=${options.size}`;
+  const resp = await fetch(url);
+  return await resp.json();
 }
 
 module.exports = { search, keyword };

build/prep-release.js

@@ -7,6 +7,7 @@
 // See also RELEASE.md.
 //
 // Inspired by <https://github.com/jquery/jquery-release>.
+'use strict';
 
 const fs = require('fs');
 const path = require('path');

build/q4000-template.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const path = require('path');
 

build/reproducible-builds.js

@@ -4,6 +4,7 @@
 // * Node.js 18+, npm 10+
 // * Git 2.11+
 // * tar, shasum, gunzip (preinstalled on Linux/macOS)
+'use strict';
 
 const cp = require('child_process');
 const fs = require('fs');

build/review-package.js

@@ -1,8 +1,8 @@
 // Helper for reviewing build artefacts against a past release.
 //
 // See also RELEASE.md.
-
 /* eslint-env node */
+'use strict';
 
 const cp = require('child_process');
 const fs = require('fs');

build/site-set-version.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 
 const { CommandError, isValidVersion, versionAnywhereRegPattern } = require('./utils.js');

build/site-update-plugins.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const { keyword } = require('./npm-search.js');
 

build/utils.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const cp = require('child_process');
 const fs = require('fs');
 const https = require('https');

demos/bundlers/Gruntfile.js

@@ -1,4 +1,5 @@
 /* eslint-env node */
+'use strict';
 module.exports = function (grunt) {
   grunt.loadNpmTasks('grunt-contrib-connect');
   grunt.loadNpmTasks('grunt-contrib-qunit');

demos/grunt-contrib-qunit/Gruntfile.js

@@ -1,4 +1,5 @@
 /* eslint-env node */
+'use strict';
 module.exports = function (grunt) {
   grunt.loadNpmTasks('grunt-contrib-qunit');
 

rollup.config.js

@@ -1,4 +1,5 @@
 /* eslint-env node */
+'use strict';
 
 const { babel } = require('@rollup/plugin-babel');
 const { nodeResolve } = require('@rollup/plugin-node-resolve');

src/cli/require-from-cwd.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = function requireFromCWD (mod) {
   const resolvedPath = require.resolve(mod, { paths: [process.cwd()] });
   return require(resolvedPath);

src/cli/require-qunit.js

@@ -1,5 +1,9 @@
-// Depending on the exact usage, QUnit could be in one of several places, this
-// function handles finding it.
+'use strict';
+
+/**
+ * Depending on the exact usage, QUnit could be in one of several places, this
+ * function handles finding it.
+ */
 module.exports = function requireQUnit (resolve = require.resolve) {
   try {
     // For: