Core: Remove deprecated QUnit.onError() and `QUnit.onUnhandledRejec…

…tion()`

Deprecated since QUnit 2.17.0. Use `QUnit.onUncaughtException()` instead.

Ref #1638.

Gruntfile.js

@@ -127,7 +127,6 @@ module.exports = function (grunt) {
         'test/main/dump.js',
         'test/main/each.js',
         'test/main/modules.js',
-        'test/main/onError.js',
         'test/main/onUncaughtException.js',
         'test/main/promise.js',
         'test/main/setTimeout.js',

docs/api/extension/QUnit.onUncaughtException.md

@@ -1,7 +1,7 @@
 ---
 layout: page-api
 title: QUnit.onUncaughtException()
-excerpt: Handle a global error.
+excerpt: Report a global error.
 groups:
  - extension
 version_added: "2.17.0"
@@ -12,12 +12,22 @@ redirect_from:
 
 `QUnit.onUncaughtException( error )`
 
-Handle a global error that should result in a failed test run.
+Report a global error that should result in a failed test run.
 
 | name | description |
 |------|-------------|
 | `error` (any) | Usually an `Error` object, but any other thrown or rejected value may be given as well. |
 
+
+This method can be safely called at any time, including between or outside tests. It is designed for use by plugins and integration layers.
+
+In general, you should not use this method and instead throw an error. QUnit automatically finds and reports uncaught errors. The following are handled by default and should not be connected to `QUnit.onUncaughtException()` a second time:
+
+* HTML Runner: `window.onerror`
+* HTML Runner: `window.addEventListener('unhandledrejection', …)`
+* QUnit CLI: `process.on('unhandledRejection', …)`
+* QUnit CLI: `process.on('uncaughtException', …)`
+
 ## Examples
 
 ```js
@@ -26,11 +36,11 @@ QUnit.onUncaughtException(error);
 ```
 
 ```js
-process.on('uncaughtException', QUnit.onUncaughtException);
+process.on('unhandledExample', QUnit.onUncaughtException);
 ```
 
 ```js
-window.addEventListener('unhandledrejection', function (event) {
+window.addEventListener('unhandledexample', function (event) {
   QUnit.onUncaughtException(event.reason);
 });
 ```

src/core.js

@@ -4,7 +4,6 @@ import equiv from './equiv';
 import dump from './dump';
 import { runSuite, module } from './module';
 import Assert from './assert';
-import Logger from './logger';
 import Test, { test, pushFailure } from './test';
 import exportQUnit from './export';
 import reporters from './reporters';
@@ -17,7 +16,6 @@ import { sourceFromStacktrace } from './core/stacktrace';
 import ProcessingQueue from './core/processing-queue';
 
 import { on, emit } from './events';
-import onWindowError from './core/onerror';
 import onUncaughtException from './core/on-uncaught-exception';
 import diff from './core/diff';
 
@@ -50,7 +48,6 @@ extend(QUnit, {
   is,
   objectType,
   on,
-  onError: onWindowError,
   onUncaughtException,
   pushFailure,
 
@@ -94,12 +91,6 @@ extend(QUnit, {
     }
   },
 
-  onUnhandledRejection: function (reason) {
-    Logger.warn('QUnit.onUnhandledRejection is deprecated and will be removed in QUnit 3.0.' +
-      ' Please use QUnit.onUncaughtException instead.');
-    onUncaughtException(reason);
-  },
-
   stack: function (offset) {
     offset = (offset || 0) + 2;
     return sourceFromStacktrace(offset);

src/test.js

@@ -57,15 +57,14 @@ export default function Test (settings) {
   }
 
   // Queuing a late test after the run has ended is not allowed.
-  // This was once supported for internal use by QUnit.onError().
+  // This was once supported for internal use by QUnit.onUncaughtException(),
+  // to render a "global error" if the uncaught error happened outside a test
+  // and after the runEnd event. This was unstable and could be missed by CI.
+  // (Meaning the CI would pass despite the late-failing test).
   // Ref https://github.com/qunitjs/qunit/issues/1377
   if (config.pq.finished) {
-    // Using this for anything other than onError(), such as testing in QUnit.done(),
-    // is unstable and will likely result in the added tests being ignored by CI.
-    // (Meaning the CI passes irregardless of the added tests).
-    //
     // TODO: Make this an error in QUnit 3.0
-    // throw new Error( "Unexpected test after runEnd" );
+    // throw new Error( 'Unexpected test after runEnd. To report errors, consider calling QUnit.onUncaughtException() instead.' );
     Logger.warn('Unexpected test after runEnd. This is unstable and will fail in QUnit 3.0.');
     return;
   }

test/index.html

@@ -14,7 +14,6 @@
   <script src="main/dump.js"></script>
   <script src="main/each.js"></script>
   <script src="main/modules.js"></script>
-  <script src="main/onError.js"></script>
   <script src="main/onUncaughtException.js"></script>
   <script src="main/promise.js"></script>
   <script src="main/setTimeout.js"></script>

test/mozjs.js

@@ -20,7 +20,6 @@ loadRelativeToScript('../test/main/deepEqual.js');
 loadRelativeToScript('../test/main/dump.js');
 loadRelativeToScript('../test/main/each.js');
 // loadRelativeToScript( "../test/main/modules.js" ); // Requires setTimeout
-loadRelativeToScript('../test/main/onError.js');
 loadRelativeToScript('../test/main/onUncaughtException.js');
 loadRelativeToScript('../test/main/promise.js');
 loadRelativeToScript('../test/main/setTimeout.js');

test/webWorker-worker.js

@@ -14,7 +14,6 @@ importScripts(
   'main/dump.js',
   'main/each.js',
   'main/modules.js',
-  'main/onError.js',
   'main/onUncaughtException.js',
   'main/promise.js',
   'main/setTimeout.js',