-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2057: Use randomly generated GREASE transport parameter. #2058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this seems nice to have.
811d345
to
ab98f38
Compare
86a6a35
to
3c373d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, thanks for working on this!
@djc thanks you very much for review! I've fixed code according to suggestions and also additionally validated comments grammar with ChatGPT and fixed several other mistakes highlighted by it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is there anything else I can do to help move this PR toward being merged? |
Pay for the maintenance you're getting for free? We're volunteer maintainers so please be a little more patient. |
Thanks for working on this! |
Sorry, I didn't intend to make a pressure on you. I understand you are volunteers with a lot of Rust projects to maintain. I just wanted to make sure I didn't miss anything required. Regarding the donations I'll talk again to company I work for to allocate some budget next year to support OSS project it rely on. |
No worries, I can see how it might have been confusing that this wasn't merged yet after we both approved it -- I get a bit stingy when I get the feeling of being pressured.
Any efforts in that direction are much appreciated, thanks! |
As a first step to make
quinn
be less vulnerable to fingerprinting I propose to generate GREASE transport parameter randomly.