Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): Fix the download of the Chinese Windows ISO. #1540

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

debuggerx01
Copy link
Contributor

Description

In Microsoft's new JSON API to fetch skuid & url, the response are:

{
    "Skus": [
        ……,
        {
            "Id": "18474",
            "Description": "Redstone Windows Consumer x64 OEM/Retail ZH-CN DVD9",
            "ProductDisplayName": "Windows 11 24H2",
            "Language": "Chinese (Simplified)",
            "LocalizedLanguage": "Chinese Simplified",
            "LocalizedProductDisplayName": "Windows 11  Chinese (Simplified)",
            "ProductEditionName": null,
            "FriendlyFileNames": [
                "Win11_24H2_Chinese_Simplified_x64.iso"
            ]
        },
        ……,
        {
            "Id": "18480",
            "Description": "Redstone Windows Consumer x64 OEM/Retail en-us DVD9",
            "ProductDisplayName": "Windows 11 24H2",
            "Language": "English",
            "LocalizedLanguage": "English (United States)",
            "LocalizedProductDisplayName": "Windows 11  English",
            "ProductEditionName": null,
            "FriendlyFileNames": [
                "Win11_24H2_English_x64.iso"
            ]
        },
        ……
    ],
    ……
}

The LocalizedLanguage does not match "Chinese (Simplified)" because it is labeled as "Chinese Simplified", although the Language field is working properly.

Resolves #1528

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions

@debuggerx01 debuggerx01 changed the title Fix the download of the Chinese Windows ISO. fix(windows): Fix the download of the Chinese Windows ISO. Dec 30, 2024
@debuggerx01 debuggerx01 changed the title fix(windows): Fix the download of the Chinese Windows ISO. fix: Fix the download of the Chinese Windows ISO. Dec 30, 2024
@debuggerx01 debuggerx01 changed the title fix: Fix the download of the Chinese Windows ISO. fix(windows): Fix the download of the Chinese Windows ISO. Dec 30, 2024
@philclifford philclifford merged commit 238ec98 into quickemu-project:master Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: quickget windows 10 or 11 fails when getting language SKU ID
2 participants