Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): Use new Microsoft JSON API to fix URL generation #1534

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(windows): Use new Microsoft JSON API to fix URL generation #1534

merged 1 commit into from
Dec 20, 2024

Conversation

lj3954
Copy link
Member

@lj3954 lj3954 commented Dec 20, 2024 •
edited
Loading

Description

Update download_windows_workstation function to use Microsoft's new JSON API to fetch skuid & url. The previous method no longer is functional.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@philclifford philclifford merged commit 2c22f0c into quickemu-project:master Dec 20, 2024
6 checks passed
@lj3954 lj3954 deleted the fix_windows branch December 20, 2024 17:57
philclifford
philclifford reviewed Dec 20, 2024
View reviewed changes
quickget Show resolved Hide resolved
@flexiondotorg flexiondotorg mentioned this pull request Dec 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philclifford philclifford philclifford approved these changes

@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: quickget windows 10 or 11 fails when getting language SKU ID
2 participants
@lj3954 @philclifford