pgupgrade: add init container to delay startup of old deployment (#984) (PROJQUAY-8092) #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JQUAY-8092) (quay#984) waits for existing postgresql pod to scale down before the old pod is up Co-authored-by: Shubhra Deshpande <shubhrajayant+github.com>
|
LGTM |
deshpandevlab
changed the title
deshpandevlab
approved these changes
Oct 21, 2024
|
What about db containters where shutdown takes more than 30 seconds? |
|
this should cover most scenario's, @jonathankingfc is working on another PR that will ensure the previous deployment completes before starting the next which will go out in the next z-stream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waits for existing postgresql pod to scale down before the old pod is up