Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split apk out of alpine #1070

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

jbergstroem
Copy link
Contributor

Refs: #923

@jbergstroem jbergstroem requested a review from a team as a code owner September 24, 2023 19:20
@jbergstroem jbergstroem requested review from hdonnay and removed request for a team September 24, 2023 19:20
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
alpine/ecosystem.go 0.00% <0.00%> (ø)
apk/scanner.go 79.22% <40.00%> (ø)

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

hdonnay
hdonnay previously approved these changes Sep 28, 2023
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll rebase this and merge it when I get a moment.

@jbergstroem
Copy link
Contributor Author

I'll rebase this and merge it when I get a moment.

Great! Wasn't sure how to deal with the coverage.

Refs: quay#923
Signed-off-by: Johan Bergström <[email protected]>
@hdonnay hdonnay merged commit 8f933d9 into quay:main Oct 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants