quattor/functions/network get_subnet_params: allow to return subnet #237
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouvin
force-pushed
the
functions_network_get_subnet_params_3args
branch
from
7db5000 to
3a15f56
Compare
|
|
jrha
approved these changes
Dec 9, 2024
- Third argument added (boolean): default unchanged (subnet not returned to be compatible with the interface schema)
jouvin
force-pushed
the
functions_network_get_subnet_params_3args
branch
from
3a15f56 to
ecdcc35
Compare
|
I need to fix the problem with Another issue is related to quattor/configuration-modules-core#1787. For some reasons, it seems there is no systemd unit defined in some profiles which looks strange and probably hides another issue. |
jrha
approved these changes
Dec 11, 2024
|
See quattor/template-library-examples#42 for the details on the errors here. In summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
get_subnet_params()return value is compatible with the interface schema (/system/network/interfaces). Thus the subnet parameter which is part of theget_subnet_params()input is removed. Sometimes, it may be desirable to get it returned. To make it possible, a third optional argument has been added (boolean). Whentrue, the subnet is return. Default is unchanged (subnet not returned to be compatible with the interface schema).