ncm-network: dropin file support for main configuration of NetworkManager #1739
+63
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka7
force-pushed
the
ncm_network_nm_main_config
branch
from
cff15a3 to
aacb57b
Compare
|
not sure I understand the indentation failure here, indentation looks ok to me. |
aka7
force-pushed
the
ncm_network_nm_main_config
branch
4 times, most recently
from
2353dd3 to
6cc7a23
Compare
ned21
reviewed
Nov 20, 2024
ncm-network/src/main/pan/components/network/types/network/backend/nmstate.pan
Outdated
Show resolved
Hide resolved
| @{Set the DNS processing mode for NetworkManager} | ||
| "dns" : choice("dnsmasq", "default", "none", "systemd-resolved") | ||
| @{Specify devices for which NetworkManager should not create default wired connection} | ||
| "no-auto-default" ? string |
There was a problem hiding this comment.
Should this be a list of strings instead?
There was a problem hiding this comment.
yes probably, will require a bit more thought on this as it can be interface names or mac addresses etc,
I'm not sure who will need this right now, we don't, just added it as bonus, so I'm inclined not to include this in this PR, and look into later, perhaps, if need arise?
|
The lines with indentation problems aren't ones you've touched, so feel free to ignore them. |
…ager switching to us dropin file support for main configuration of NetworkManager instead of jsut manage_dns option
aka7
force-pushed
the
ncm_network_nm_main_config
branch
from
6cc7a23 to
e453fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop-in file support for main configuration section of NetworkManager
closes #1740
Why the change is necessary.
Allow capability for adding additional options for NetworkManager.conf [main] section.
What backwards incompatibility it may introduce.
manage_dns options will no longer be needed.