Upload built binaries to artifacts #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
requested changes
Sep 30, 2024
.github/workflows/ci.yml
Outdated
| command: objcopy | ||
| args: --release --bin thermostat-eem -- -O binary ${{ matrix.toolchain }}-thermostat-eem.bin | ||
| - name: Upload a Build Artifact | ||
| uses: actions/[email protected] |
.github/workflows/ci.yml
Outdated
| with: | ||
| command: objcopy | ||
| args: --release --bin thermostat-eem -- -O binary ${{ matrix.toolchain }}-thermostat-eem.bin | ||
| - name: Upload a Build Artifact |
There was a problem hiding this comment.
"a"?
Please read and make useful when copy-pasting.
.github/workflows/ci.yml
Outdated
| @@ -72,10 +72,26 @@ jobs: | |||
| toolchain: ${{ matrix.toolchain }} | |||
| target: thumbv7em-none-eabihf | |||
| override: true | |||
| components: llvm-tools-preview | |||
| - name: Install binary utils | |||
| uses: actions-rs/cargo@v1 | |||
.github/workflows/ci.yml
Outdated
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: objcopy | ||
| args: --release --bin thermostat-eem -- -O binary ${{ matrix.toolchain }}-thermostat-eem.bin |
There was a problem hiding this comment.
Why the toolchain in the name?
You'd only want the upload for a single toolchain.
But instead potentially and likely for multiple features.
There was a problem hiding this comment.
Well, I didn't know which binary is regarded to be official. For now I left only stable binary and moved cargo binutils under condition, so it would consume a bit less time quote.
thomasfire
force-pushed
the
main
branch
4 times, most recently
from
c0efc92 to
25853f3
Compare
Signed-off-by: Egor Savkin <[email protected]>
Signed-off-by: Egor Savkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses objcopy before uploading, so it can be more useful for end-users.