Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of MongoDB used for testing to 7.0 #45160

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 17, 2024

It is not the latest (8.0 was released in November) but it's probably the most common used and also it's consistent with the version used as a container.

Hopefully, this will be compatible with Ubuntu 22 and 24.

@gsmet
Copy link
Member Author

gsmet commented Dec 23, 2024

@loicmathieu this will be needed for the upcoming switch to Ubuntu 24. Unfortunately, things are not correctly stopped on Windows (or some other issues) which lead to CI stalling and being cancelled after 6 hours.

I think we are not the only one with the issue: flapdoodle-oss/de.flapdoodle.embed.mongo.spring#47 .

I'm not entirely sure why MongoDB 7 won't stop properly on Windows... but it seems something is off.

@loicmathieu
Copy link
Contributor

Flapdoodle on Windows has always been a pain, I remember having the same issue when update to a major version of Flapdoodle.
I wonder if we should move more tests to containers and only keep the test resource that uses Flapdoodl for cluster tests (with replicas).
As a workaround we may disable those tests on windows and create a followup issue to re-enable them later (we already did that for some months).

Copy link

github-actions bot commented Dec 26, 2024

🎊 PR Preview 1ffcee2 has been successfully built and deployed to https://quarkus-pr-main-45160-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

It is not the latest (8.0 was released in November) but it's probably
the most common used and also it's consistent with the version used as a
container.

Hopefully, this will be compatible with Ubuntu 22 and 24.
It seems that the replicas are not correctly shut down and it leads to
job timeouts.
@gsmet gsmet marked this pull request as ready for review December 28, 2024 11:08
@gsmet
Copy link
Member Author

gsmet commented Dec 28, 2024

@gastaldi @geoand FYI probably something to merge early next year as CI will fail as soon as Ubuntu 24 becomes the default for our CI (it's already the case in my fork).

Copy link

quarkus-bot bot commented Dec 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 01060f2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit df371c2 into quarkusio:main Dec 28, 2024
39 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 28, 2024
@gsmet
Copy link
Member Author

gsmet commented Dec 28, 2024

@loicmathieu FYI the problem is specific to replica tests. So there might be something off there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants