Update test suite for webauthn4j changes #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am busy ATM, but I'll let (any of) @rsvoboda @jcarranzan review, thanks a million time for looking into this. |
|
Thanks @FroMage ,I'll review it. |
|
run tests |
rsvoboda
approved these changes
Dec 13, 2024
security/webauthn/src/test/java/io/quarkus/ts/security/webauthn/AbstractWebAuthnTest.java
Show resolved
Hide resolved
security/webauthn/src/test/java/io/quarkus/ts/security/webauthn/AbstractWebAuthnTest.java
Outdated
Show resolved
Hide resolved
security/webauthn/src/main/java/io/quarkus/ts/security/webauthn/security/MyWebAuthnSetup.java
Outdated
Show resolved
Hide resolved
jcarranzan
reviewed
Dec 13, 2024
security/webauthn/src/test/java/io/quarkus/ts/security/webauthn/AbstractWebAuthnTest.java
Outdated
Show resolved
Hide resolved
|
OCP failures in external apps are on investigation todo list, not related to this PR. |
jcarranzan
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
WebAuthn has changed a lot since the last time I looked at it. Thanks, @FroMage, for the fix and the code adaptation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the webauthn test compile and run with the latest Quarkus
mainchanges.