-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some deprecated quarkus.health
properties to quarkus.smallrye-health
#2230
Rename some deprecated quarkus.health
properties to quarkus.smallrye-health
#2230
Conversation
run tests |
1 similar comment
run tests |
OCP seems having problems to find |
run tests |
@jedla97 I'll deal with OCP failures, but can you rebase please? I'd like to see same failures on current main (which I totally expect from what I read, but it's just surprising). |
f0dfb6f
to
4428fad
Compare
run tests |
For GH CI, it seems that |
Fix will be in next community push of Quarkus 999-SNAPSHOT, I think that happens once per day |
I need to adjust our internal Nexus to fix OCP and I need to go offline for few hours. I'll deal with OCP in the evening. |
I can trigger it, I guess I will so the CI work is unblocked |
@jedla97 @michalvavrik new Quarkus main bits are deployed @jedla97 pls rebase the PR |
4428fad
to
da788e1
Compare
run tests |
2 similar comments
run tests |
run tests |
See https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#smallrye-health `quarkus.health.extensions.enabled` → `quarkus.smallrye-health.extensions.enabled` `quarkus.health.openapi.included` → `quarkus.smallrye-health.openapi.included`
da788e1
to
2adc467
Compare
run tests |
1 similar comment
run tests |
@michalvavrik when you have time can you look at this. For the GH error, I see same on daily so it's not related. |
yeah, I'll look tomorrow.
I trust you, but could you just rebase? I'd like to see OCP CI at any rate in some PR, so it can be this one as well. |
No, I can see that OCP CI run, so it' s fine, let me merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, thanks for your patience
Summary
Renaming
quarkus.health.extensions.enabled
→quarkus.smallrye-health.extensions.enabled
quarkus.health.openapi.included
→quarkus.smallrye-health.openapi.included
For more info see https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#smallrye-health
Please select the relevant options.
run tests
phrase in comment)Checklist: