Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some deprecated quarkus.health properties to quarkus.smallrye-health #2230

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Nov 29, 2024

Summary

Renaming

  • quarkus.health.extensions.enabledquarkus.smallrye-health.extensions.enabled
  • quarkus.health.openapi.includedquarkus.smallrye-health.openapi.included

For more info see https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#smallrye-health

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Nov 29, 2024

run tests

1 similar comment
@jedla97
Copy link
Member Author

jedla97 commented Nov 30, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented Nov 30, 2024

OCP seems having problems to find 999-SNAPSHOT quarkus-test-preparer leaving this problam to Monday

@michalvavrik
Copy link
Member

run tests

@michalvavrik michalvavrik self-requested a review December 10, 2024 09:25
@michalvavrik
Copy link
Member

@jedla97 I'll deal with OCP failures, but can you rebase please? I'd like to see same failures on current main (which I totally expect from what I read, but it's just surprising).

@jedla97 jedla97 force-pushed the rename-depraceted-property branch from f0dfb6f to 4428fad Compare December 10, 2024 09:42
@michalvavrik
Copy link
Member

run tests

@jedla97
Copy link
Member Author

jedla97 commented Dec 10, 2024

For GH CI, it seems that vectorized/redpanda was relocated to redpandadata/redpanda

@rsvoboda
Copy link
Member

@rsvoboda
Copy link
Member

Fix will be in next community push of Quarkus 999-SNAPSHOT, I think that happens once per day

@michalvavrik
Copy link
Member

I need to adjust our internal Nexus to fix OCP and I need to go offline for few hours. I'll deal with OCP in the evening.

@rsvoboda
Copy link
Member

@rsvoboda
Copy link
Member

I can trigger it, I guess I will so the CI work is unblocked

@rsvoboda
Copy link
Member

@jedla97 @michalvavrik new Quarkus main bits are deployed

@jedla97 pls rebase the PR

@jedla97 jedla97 force-pushed the rename-depraceted-property branch 2 times, most recently from 4428fad to da788e1 Compare December 10, 2024 23:05
@michalvavrik
Copy link
Member

run tests

2 similar comments
@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

run tests

See https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.14#smallrye-health
    `quarkus.health.extensions.enabled` → `quarkus.smallrye-health.extensions.enabled`
    `quarkus.health.openapi.included` → `quarkus.smallrye-health.openapi.included`
@jedla97 jedla97 force-pushed the rename-depraceted-property branch from da788e1 to 2adc467 Compare December 12, 2024 09:38
@jedla97
Copy link
Member Author

jedla97 commented Dec 12, 2024

run tests

1 similar comment
@jedla97
Copy link
Member Author

jedla97 commented Dec 12, 2024

run tests

@jedla97
Copy link
Member Author

jedla97 commented Dec 12, 2024

@michalvavrik when you have time can you look at this.

For the GH error, I see same on daily so it's not related.
For openshift it was fixed by #2237

@michalvavrik
Copy link
Member

michalvavrik commented Dec 12, 2024

For the GH error, I see same on daily so it's not related.

yeah, I'll look tomorrow.

For openshift it was fixed by #2237

I trust you, but could you just rebase? I'd like to see OCP CI at any rate in some PR, so it can be this one as well.

@michalvavrik
Copy link
Member

No, I can see that OCP CI run, so it' s fine, let me merge.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks for your patience

@michalvavrik michalvavrik merged commit df9f462 into quarkus-qe:main Dec 12, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants