fix: use service account name instead of deployment name #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #932 Signed-off-by: Chris Laprun <[email protected]>
xstefank
reviewed
Sep 10, 2024
|
|
||
| public class ConfiguredServiceAccountNameShouldBeUsedTest { | ||
|
|
||
| public static final String APPLICATION_NAME = "configured-service-account-name"; |
There was a problem hiding this comment.
@metacosm isn't this conflicting your other draft PR?
There was a problem hiding this comment.
Yes, it is, I created the other one to show current progress and discuss things with @iocanel. This one will get a workaround with the current code to provide a fix but, ultimately, the proper way to handle things should be what has been started in the other PR.
Signed-off-by: Chris Laprun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932
Signed-off-by: Chris Laprun [email protected]