Refactor RNG ownership semantics #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change `stim::TableauSimulator`'s constructor to require a move-reference for its rng - Change `stim::FrameSimulator`'s constructor to require a move-reference for its rng - Change `stim::FrameSimulator`'s RNG from a reference to a normal object owned by the simulator - Replace SHARED_TEST_RNG method with INDEPENDENT_TEST_RNG method - Rewrite all tests to use INDEPENDENT_TEST_RNG, fixing potential overlaps in randomness - Also fix some `pybind11::args args` -> `const pybind11::args &args` warnings - Also fix some int vs size_t comparison warnings Fixes #353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stim::TableauSimulator's constructor to require a move-reference for its rngstim::FrameSimulator's constructor to require a move-reference for its rngstim::FrameSimulator's RNG from a reference to a normal object owned by the simulatorpybind11::args args->const pybind11::args &argswarningsFixes #353