Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S date distribution #2588

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

S date distribution #2588

wants to merge 12 commits into from

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Nov 29, 2023 •
edited
Loading

TODO for later:
Maybe get this to work:
image

OAGr added 11 commits November 28, 2023 13:29
@OAGr
Converted SDate to store number
758b883
@OAGr
Converted SDate to SDate and SDateNumber
250c499
@OAGr
SDate -> SDateDist
8c23de8
@OAGr
Merged with main
8d16a6e
@OAGr
Merge branch 'dateScale' into SDate-distribution
a965ef1 
* dateScale: (28 commits)
  Quick last fix
  Remove generated files
  Fixing linting errors
  enable eqeqeq eslint rule in squiggle-lang
  Minor cleanup
  move each extension to a separate file
  cleanups, comments
  extract editor extensions to react hooks
  extract codemirror logic from CodeEditor component
  move languageSupport dir
  various fixes after review
  migration
  one more type fix
  fix types
  minor UI cleanups
  Show definitions from all users
  Updated documentation and changeset
  Simple implementation of Dist.median, Number.quantile, Number.median
  frontend invite link flow
  fix tests
  ...
@OAGr
Simple date dists are working
f61867d
@OAGr
Gradually getting duration dist to work
2919deb
@OAGr
Minor refactor
21db78c
@OAGr
Very simple DateWidget customization for Durations
a13863f
@OAGr
Moved unit conversion logic into durationUnit.ts
b0b814f
@OAGr
Improved DateWidget and DurationWidget
57bc4a8
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2baed70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Dec 1, 2023 5:38am
squiggle-components ✅ Ready (Inspect) Visit Preview Dec 1, 2023 5:38am
squiggle-website ✅ Ready (Inspect) Visit Preview Dec 1, 2023 5:38am
1 Ignored Deployment
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 5:38am

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Ensure that all variables and functions have descriptive names.
  • Apply: Avoid using unnecessary separators or extra characters in code.
  • Apply: Use consistent indentation and spacing throughout the code.
  • Apply: Ensure that all code is properly formatted and follows the style guide.
  • Apply: Avoid using magic numbers or hard-coded values in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berekuk berekuk Awaiting requested review from berekuk berekuk will be requested when the pull request is marked ready for review berekuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Main project
Status: 🆕 To prioritize
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OAGr