Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data tables references #2150

Merged
merged 6 commits into from
Dec 26, 2024
Merged

Data tables references #2150

merged 6 commits into from
Dec 26, 2024

Conversation

davidfig
Copy link
Collaborator

No description provided.

@davidfig davidfig added the prototype exploring an idea that can be played with label Dec 25, 2024
@davidfig davidfig self-assigned this Dec 25, 2024
Copy link

qa-wolf bot commented Dec 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Dec 26, 2024 2:36pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2150 December 25, 2024 18:02 Inactive
@davidkircos davidkircos requested a deployment to quadratic-api-dev-pr-2150 December 26, 2024 13:33 Abandoned
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2150 December 26, 2024 13:34 Inactive
@davidfig davidfig merged commit ec4117f into data-tables-v1 Dec 26, 2024
6 of 10 checks passed
@davidfig davidfig deleted the data-tables-ref branch December 26, 2024 13:35
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 91.29721% with 53 lines in your changes missing coverage. Please review.

Please upload report for BASE (data-tables-v1@45e9432). Learn more about missing BASE report.

Files with missing lines Patch % Lines
quadratic-core/src/a1/table_ref/parse.rs 90.41% 16 Missing ⚠️
quadratic-core/src/a1/table_ref/tokenize.rs 94.98% 15 Missing ⚠️
quadratic-core/src/a1/error.rs 0.00% 8 Missing ⚠️
quadratic-core/src/a1/table_ref/column_range.rs 81.39% 8 Missing ⚠️
quadratic-core/src/a1/table_ref/display.rs 94.50% 5 Missing ⚠️
quadratic-core/src/a1/table_ref/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             data-tables-v1    #2150   +/-   ##
=================================================
  Coverage                  ?   88.23%           
=================================================
  Files                     ?      324           
  Lines                     ?    66493           
  Branches                  ?        0           
=================================================
  Hits                      ?    58669           
  Misses                    ?     7824           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed prototype exploring an idea that can be played with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants