Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS properly receives 1D or 2D arrays from q.cells #2137

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

davidfig
Copy link
Collaborator

  • Convert 2D array to 1D when possible, except in cases where the output may grow (eg, "2:" or "B5:")

Copy link

qa-wolf bot commented Dec 19, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Dec 19, 2024 2:28pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2137 December 19, 2024 14:02 Inactive
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (5c844ef) to head (0a56bef).
Report is 2 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #2137   +/-   ##
=======================================
  Coverage   88.91%   88.92%           
=======================================
  Files         305      305           
  Lines       62021    62028    +7     
=======================================
+ Hits        55149    55157    +8     
+ Misses       6872     6871    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyushAgrawal-A2 AyushAgrawal-A2 merged commit 1fcd3fb into qa Dec 19, 2024
15 of 16 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the fix-js-cells branch December 19, 2024 15:22
@ddimaria ddimaria restored the fix-js-cells branch December 23, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants