Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted code cell artifacts still showing up #2081

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #2078

Copy link

qa-wolf bot commented Nov 17, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Nov 17, 2024
Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 17, 2024 4:06am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2081 November 17, 2024 03:47 Inactive
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (32c3a26) to head (fc5f565).
Report is 31 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #2081      +/-   ##
==========================================
- Coverage   93.06%   90.82%   -2.24%     
==========================================
  Files         215      260      +45     
  Lines       54338    57546    +3208     
==========================================
+ Hits        50568    52269    +1701     
- Misses       3770     5277    +1507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@davidfig
Copy link
Collaborator

Nice find

Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was still able to get this bug on this PR after refreshing.

So I am not sure if it's a rendering issue vs a file issue. It's fixed on sheets when duplicating. but persistent after reloading.

@luke-quadratic is seeing if he can demonstrate in a video

@luke-quadratic
Copy link
Contributor

Have tried very hard, cannot recreate; is minimally a big improvement since this is persistent and easy to recreate in prod.

Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok well, let's merge and continue to monitor and see if it comes back up.

@davidkircos davidkircos merged commit ba07e0c into qa Nov 19, 2024
15 of 16 checks passed
@davidkircos davidkircos deleted the ayush/2078 branch November 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted code cell artifacts still showing up
4 participants