-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lock file maintenance (dependencies update and dedupe) #2061
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2061 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 260 260
Lines 57540 57540
=======================================
Hits 52266 52266
Misses 5274 5274 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
db9eeb7
to
816568b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch appears to work normally
@@ -82,7 +81,7 @@ | |||
"prisma": "^5.5.2", | |||
"ts-node": "^10.9.1", | |||
"ts-node-dev": "^2.0.0", | |||
"typescript": "^5.4.5" | |||
"typescript": "^5.6.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If typescript is specified in the root package.json
, we shouldn't have to also include it in quadratic-api
and quadratic-client
and quadratic-shared
— no? Isn't that the purpose of the root package.json
: to define (and coordinate) deps shared across multiple child packages?
@@ -158,7 +157,7 @@ | |||
"sass": "^1.69.5", | |||
"serve": "^14.2.0", | |||
"tailwindcss": "^3.3.5", | |||
"typescript": "^5.4.5", | |||
"typescript": "^5.6.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -35,7 +35,7 @@ | |||
"ts-mocha": "^9.0.2", | |||
"tsd": "^0.24.1", | |||
"typedoc": "^0.25.1", | |||
"typescript": "^4.6.4", | |||
"typescript": "^5.6.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we want to update this...or, at least that updating it is doing anything? Like this package.json isn't actually doing anything is it? Aren't all the files in public/
just static files that get copied over and there's no npm i
going on with anything in here?
Ultimately if this file doesn't actually do anything, then it doesn't really matter if you update it, other than it serves as a historical marker for when the pyodide
package was copied in here (and what it's declared deps were when it got put here)
@@ -8,7 +8,7 @@ | |||
"test": "echo \"Error: no test specified\" && exit 1" | |||
}, | |||
"dependencies": { | |||
"typescript": "^5.6.2", | |||
"typescript": "^5.6.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before:
after: