Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lock file maintenance (dependencies update and dedupe) #2061

Closed
wants to merge 1 commit into from

Conversation

AyushAgrawal-A2
Copy link
Collaborator

before:

image

after:

image

Copy link

qa-wolf bot commented Nov 11, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Nov 11, 2024
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 11, 2024 10:42am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 09:21 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 09:36 Inactive
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (432e052) to head (816568b).
Report is 140 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #2061   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         260      260           
  Lines       57540    57540           
=======================================
  Hits        52266    52266           
  Misses       5274     5274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 09:45 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 10:10 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 10:11 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2061 November 11, 2024 10:18 Inactive
@AyushAgrawal-A2 AyushAgrawal-A2 changed the title chore: lock file maintenace chore: lock file maintenance (dependencies update and dedupe) Nov 11, 2024
Base automatically changed from ayush/ai_panel to qa November 12, 2024 00:11
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch appears to work normally

@@ -82,7 +81,7 @@
"prisma": "^5.5.2",
"ts-node": "^10.9.1",
"ts-node-dev": "^2.0.0",
"typescript": "^5.4.5"
"typescript": "^5.6.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If typescript is specified in the root package.json, we shouldn't have to also include it in quadratic-api and quadratic-client and quadratic-shared — no? Isn't that the purpose of the root package.json: to define (and coordinate) deps shared across multiple child packages?

@@ -158,7 +157,7 @@
"sass": "^1.69.5",
"serve": "^14.2.0",
"tailwindcss": "^3.3.5",
"typescript": "^5.4.5",
"typescript": "^5.6.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -35,7 +35,7 @@
"ts-mocha": "^9.0.2",
"tsd": "^0.24.1",
"typedoc": "^0.25.1",
"typescript": "^4.6.4",
"typescript": "^5.6.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we want to update this...or, at least that updating it is doing anything? Like this package.json isn't actually doing anything is it? Aren't all the files in public/ just static files that get copied over and there's no npm i going on with anything in here?

Ultimately if this file doesn't actually do anything, then it doesn't really matter if you update it, other than it serves as a historical marker for when the pyodide package was copied in here (and what it's declared deps were when it got put here)

@@ -8,7 +8,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"typescript": "^5.6.2",
"typescript": "^5.6.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidkircos davidkircos added the status: open question Unclear - needs better defined before becoming a high prio issue label Nov 13, 2024
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/lock_file branch November 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: open question Unclear - needs better defined before becoming a high prio issue status: ready for user test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants