-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable few default keybindings in inline monaco editor #2047
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2047 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 215 215
Lines 54338 54338
=======================================
Hits 50568 50568
Misses 3770 3770 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes cmd+g bug
Noting that cmd+g from within cell opens browser's find on page. Fix is still improvement but if max nitpicking then maybe cmd+g from inside cell should open the go-to prompt in sheet? |
Yeah, it's the same with Command + F when inline. It opens the browser's find menu, and it should open to sheet find menu. |
closes #1996