Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable few default keybindings in inline monaco editor #2047

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #1996

Copy link

qa-wolf bot commented Nov 7, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Nov 7, 2024
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 14, 2024 2:55pm

@AyushAgrawal-A2 AyushAgrawal-A2 linked an issue Nov 7, 2024 that may be closed by this pull request
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2047 November 7, 2024 14:18 Inactive
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (32c3a26) to head (6a36286).
Report is 9 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #2047   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files         215      215           
  Lines       54338    54338           
=======================================
  Hits        50568    50568           
  Misses       3770     3770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes cmd+g bug

@luke-quadratic
Copy link
Contributor

Noting that cmd+g from within cell opens browser's find on page. Fix is still improvement but if max nitpicking then maybe cmd+g from inside cell should open the go-to prompt in sheet?

Base automatically changed from ayush/update_vite to qa November 8, 2024 15:32
@davidkircos
Copy link
Collaborator

Noting that cmd+g from within cell opens browser's find on page. Fix is still improvement but if max nitpicking then maybe cmd+g from inside cell should open the go-to prompt in sheet?

Yeah, it's the same with Command + F when inline. It opens the browser's find menu, and it should open to sheet find menu.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2047 November 12, 2024 20:19 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2047 November 12, 2024 21:29 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2047 November 13, 2024 15:33 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2047 November 13, 2024 15:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmd+g inside a cell opens monaco menu in that cell
4 participants