Search dialog triggers when manually changing sheets #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #1990 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 250 250
Lines 56531 56531
=======================================
Hits 51422 51422
Misses 5109 5109 ☔ View full report in Codecov by Sentry. |
ddimaria
reviewed
Oct 24, 2024
| found.map((found) => ({ x: Number(found.x), y: Number(found.y), sheetId: found.sheet_id.id }), 0) | ||
| ); | ||
| return; | ||
| const onChange = useCallback( |
There was a problem hiding this comment.
GH should be better at diffs. Nothing changed here except moving the function signature down a line.
ddimaria
reviewed
Oct 24, 2024
| setResults([]); | ||
| events.emit('search'); | ||
| }, | ||
| [searchOptions] |
There was a problem hiding this comment.
This seems to be the only addition
ddimaria
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1989
When searching on one sheet, if you manually change sheets, then the search dialog will search that sheet with the same options. When searching all sheets, then the behavior is the same as before.