feat: show logged in user context #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #1980 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 250 250
Lines 56525 56525
=======================================
+ Hits 51421 51422 +1
+ Misses 5104 5103 -1 ☔ View full report in Codecov by Sentry. |
jimniels
added
status: ready to merge
and removed
status: ready for code review
status: ready for user test
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the dashboard or in the app, there are times you can hit a route that results in a screen where something went wrong.
Today it's not always clear that you might be hitting that error based on who you're logged in as.
For example, I go to
/teams/team-id-1and it says "You can't access this team" and I think "I should be able to, that's weird..."But the reality is that I can't access that team because I'm not logged in as the user I think I am when I hit that screen.
So this PR makes it a lot easier to infer why you might be hitting these screens, as it will show you you're currently logged in status (if you're logged in — if you're not logged in, e.g. an anon user, it won't show this).
Examples:
You don't have permission to see team
Team not found
Unexpected error