Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter files by creator #1979

Merged
merged 6 commits into from
Nov 5, 2024
Merged

feat: filter files by creator #1979

merged 6 commits into from
Nov 5, 2024

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented Oct 17, 2024

Filter field allows inputting the file name or the creator's name and it will filter/highlight on that value

You can also click on the avatar of the person on the file and it will populate the filter field with that person's name for filtering.

Filter priority:

  • File name
  • User name
  • User email

@cla-bot cla-bot bot added the cla-signed label Oct 17, 2024
Copy link

qa-wolf bot commented Oct 17, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 1, 2024 3:36am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1979 October 17, 2024 19:24 Inactive
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (ccca1fa) to head (12adda9).
Report is 141 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1979   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         250      250           
  Lines       56531    56531           
=======================================
  Hits        51422    51422           
  Misses       5109     5109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimniels jimniels changed the title initial commit feat: filter files by creator Oct 17, 2024
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1979 October 18, 2024 20:52 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1979 October 29, 2024 15:36 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1979 November 1, 2024 03:20 Inactive
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! looks great to me!

@davidkircos davidkircos merged commit 85fd084 into qa Nov 5, 2024
16 checks passed
@davidkircos davidkircos deleted the jim-filter-files-by-creator branch November 5, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants