Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Oct 15th #1974

Merged
merged 42 commits into from
Oct 30, 2024
Merged

QA: Oct 15th #1974

merged 42 commits into from
Oct 30, 2024

Conversation

davidkircos
Copy link
Collaborator

@davidkircos davidkircos commented Oct 15, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 15, 2024
Copy link

qa-wolf bot commented Oct 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 29, 2024 4:17pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1974 October 15, 2024 19:29 Inactive
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (ec150b9) to head (da5996c).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
quadratic-rust-shared/src/sql/mysql_connection.rs 0.00% 13 Missing ⚠️
quadratic-rust-shared/src/sql/mssql_connection.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   90.97%   90.96%   -0.01%     
==========================================
  Files         250      250              
  Lines       56525    56531       +6     
==========================================
  Hits        51422    51422              
- Misses       5103     5109       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1974 October 19, 2024 01:14 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1974 October 21, 2024 22:31 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1974 October 29, 2024 15:36 Inactive
Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on functionality!

@davidkircos davidkircos merged commit 8d4e7bb into main Oct 30, 2024
16 of 18 checks passed
davidkircos added a commit that referenced this pull request Oct 30, 2024
Merge pull request #1974 from quadratichq/qa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants