Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline editor arrow key interactions (edit & enter states) #1972

Merged
merged 25 commits into from
Nov 21, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #1961

Mode indicator: (for testing, will change)
Insert Cell Ref Mode: White Icon
image

Navigate Text Mode: Black Icon
image

Copy link

qa-wolf bot commented Oct 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 15, 2024
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Nov 21, 2024 5:05pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 15, 2024 16:05 Inactive
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (51156b2) to head (5378d8b).
Report is 43 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1972      +/-   ##
==========================================
- Coverage   93.06%   90.82%   -2.24%     
==========================================
  Files         215      260      +45     
  Lines       54353    57549    +3196     
==========================================
+ Hits        50581    52271    +1690     
- Misses       3772     5278    +1506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 17, 2024 11:14 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 17, 2024 11:15 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 17, 2024 16:24 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 18, 2024 16:17 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1972 October 18, 2024 18:41 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1972 October 18, 2024 18:53 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 October 18, 2024 19:03 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 November 19, 2024 20:14 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 November 19, 2024 20:33 Inactive
Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide some spacing/padding around the icon? For example, this this screenshot, the icon size is 15x15px (instead of 20x20). Gives it a little more space to breathe.

CleanShot 2024-11-20 at 11 09 33@2x

@AyushAgrawal-A2
Copy link
Collaborator Author

Can we provide some spacing/padding around the icon? For example, this this screenshot, the icon size is 15x15px (instead of 20x20). Gives it a little more space to breathe.

CleanShot 2024-11-20 at 11 09 33@2x

@jimniels
done

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 November 20, 2024 19:40 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 November 20, 2024 20:06 Inactive
Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change where this is the default state for entering text into empty prompts:

CleanShot 2024-11-21 at 09 15 20@2x

I'm good with these current changes

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1972 November 21, 2024 16:33 Inactive
@davidkircos davidkircos merged commit 322dfbc into qa Nov 21, 2024
13 of 15 checks passed
@davidkircos davidkircos deleted the ayush/1961 branch November 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants