Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offline sync fieId #1967

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: offline sync fieId #1967

merged 1 commit into from
Oct 15, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Oct 13, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 13, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 13, 2024 0:40am

@AyushAgrawal-A2 AyushAgrawal-A2 self-assigned this Oct 13, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1967 October 13, 2024 00:18 Inactive
@codecov Codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (3b304d6) to head (e455249).
Report is 37 commits behind head on qa.

Additional details and impacted files 
@@           Coverage Diff           @@
##               qa    #1967   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         249      249           
  Lines       55862    55862           
=======================================
  Hits        50733    50733           
  Misses       5129     5129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HactarCE HactarCE changed the title fix: offline sync fileId fix: offline sync fieId Oct 14, 2024
davidkircos
davidkircos approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidkircos davidkircos merged commit 53c4e4d into qa Oct 15, 2024
16 checks passed
@davidkircos davidkircos deleted the ayush/offline_fileId branch October 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkircos davidkircos davidkircos approved these changes

@davidfig davidfig davidfig approved these changes

Assignees

@AyushAgrawal-A2 AyushAgrawal-A2

Labels
cla-signed QA bug exists in QA branch, not prod status: ready for user test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyushAgrawal-A2 @davidfig @davidkircos