Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QA Wolf): Border formatting is not working as expected #1966

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

Copy link

qa-wolf bot commented Oct 12, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 12, 2024 11:53pm

@AyushAgrawal-A2 AyushAgrawal-A2 added the QA bug exists in QA branch, not prod label Oct 12, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1966 October 12, 2024 16:29 Inactive
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (3b304d6) to head (74274b2).
Report is 37 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1966   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         249      249           
  Lines       55862    55862           
=======================================
  Hits        50733    50733           
  Misses       5129     5129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidkircos davidkircos merged commit 5878e8e into qa Oct 15, 2024
16 checks passed
@davidkircos davidkircos deleted the ayush/fix_borders_dirty branch October 15, 2024 16:15
Copy link

qa-wolf bot commented Oct 15, 2024

E2E tests

QA 1 blocking bug

Ran Status Preview Started Run time Est. dev time saved
74 workflows Done (Details) Oct 15, 2024 at 4:45 PM (UTC) 24 minutes ~29.83 hrs
✅ 70 passed

Preexisting bugs

1 Blocking bug
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

. . . . . . . .

Re-run your E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed QA bug exists in QA branch, not prod status: ready for user test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants