Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting started buttons wrapping issues #1964

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jimniels
Copy link
Collaborator

Button text shouldn't wrap, but buttons inside container should (when screens get narrow)

image

Copy link

qa-wolf bot commented Oct 11, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 11, 2024 9:35pm

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (3b304d6) to head (52c05b2).
Report is 31 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1964   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         249      249           
  Lines       55862    55862           
=======================================
  Hits        50733    50733           
  Misses       5129     5129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos added the QA bug exists in QA branch, not prod label Oct 14, 2024
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work great!

@davidkircos davidkircos merged commit 372fbf4 into qa Oct 14, 2024
16 checks passed
@davidkircos davidkircos deleted the fix-getting-started-buttons branch October 14, 2024 23:36
Copy link

qa-wolf bot commented Oct 15, 2024

E2E tests

QA 2 blocking bugs

Ran Status Preview Started Run time Est. dev time saved
74 workflows Done (Details) Oct 15, 2024 at 12:07 AM (UTC) 21 minutes ~30.33 hrs
✅ 69 passed

Preexisting bugs

2 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

. . . . . . . .

Re-run your E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants