Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows deleting of multiple columns and rows via multiselect #1960

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Oct 9, 2024

No description provided.

Copy link

qa-wolf bot commented Oct 9, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 14, 2024 8:39am

@davidfig davidfig self-assigned this Oct 9, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 12:31 Inactive
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 12:32 Inactive
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (3b304d6) to head (d4810cd).
Report is 31 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1960      +/-   ##
==========================================
+ Coverage   90.81%   90.86%   +0.04%     
==========================================
  Files         249      249              
  Lines       55862    55877      +15     
==========================================
+ Hits        50733    50771      +38     
+ Misses       5129     5106      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks good to me

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 14:55 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 15:27 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 16:06 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 9, 2024 16:07 Inactive
Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great!

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 13, 2024 22:53 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1960 October 14, 2024 08:16 Inactive
Copy link
Collaborator

@davidkircos davidkircos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidkircos davidkircos merged commit de0f1ae into qa Oct 14, 2024
16 checks passed
@davidkircos davidkircos deleted the delete-multicursor-colrows branch October 14, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed QA bug exists in QA branch, not prod status: ready for user test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants