fix: sheet gets stuck in pan mode

[AyushAgrawal-A2]

closes #1870

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Oct 7, 2024 6:27pm

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (a762cc0) to head (a51bb7b).
Report is 4 commits behind head on qa.

Additional details and impacted files

@@           Coverage Diff           @@
##               qa    #1953   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         248      248           
  Lines       55205    55205           
=======================================
  Hits        50187    50187           
  Misses       5018     5018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luke-quadratic]

Can't recreate panning bug in this branch and doesn't seem to break existing behavior

[davidkircos]

On this branch, my cursor is not changing for either moving a group of cells or auto-complete.

On qa the cursor changes to the grabber for moving and the crosshairs for autocomplete.

[AyushAgrawal-A2]

@davidkircos
fixed

[davidkircos]

Nice, this looks great to me! Fingers crossed this solves this frustrating issue!

[qa-wolf]

E2E tests

Ran	Status	Preview	Started
74 workflows	In review (Details)		Oct 7, 2024 at 7:08 PM (UTC)

⚠️ 3 failed - your wolf pack is investigating

• Members Can Leave Team

• Upload Large File

• Types: Series and Data-Frames

✅ 67 passed

• Right Click Actions

• Charts

• Filter Files by Name - My Files

• Action Visibility

• Mouse Visibility

• View Actions

• Code Editor Displays Return

• Read Python Output within Formula

• Log Out

• Removed Member No Longer Can Access Team Files

• Time Formatting

• SQL - Reference Data in Formula and Python

• Can Edit Members are Able to Invite

• Sheet Actions

• Import Files

• Can Edit Member are Able to Change Permissions

• Auto-Complete

• Resize Column width with Fill

• Discard Changes

• SQL - Create a Connection, Add Data to Database, Query Database

• Date Formatting

• Invite Member to Team

• Rename Team

• Cell Reference - Python

• Switching Tabs Persists Cursor

• Create File for Team

• Filter Files by Name - Shared with me

• AI Assistant

• Open Formula Editor

• Edit Share File Permissions

• Help Actions

• Can Stop Code Execution

• Switch between Python and Formula

• Custom time and date formatting

• Can View Team Member Cannot Edit Files

• Text Wrap, Horizontal and Vertical Alignment

• File Actions - Dashboard

• Connection goes down in Multiplayer Session

• Log In

• Drag Relative References

• Can Edit Team Member Can Edit Files

• Dashboard Views - Shared with me

• Formulas

• Spills

• Can View Members are Unable to Invite Members

• Make Changes while Network is off

• Read JavaScript Output within Formula

• Zoom Options

• Share File - Spreadsheet

• Share File - Dashboard

• Create New File

• Dashboard Views - My Files

• Number Formatting

• API Calls

• Open Python Editor

• Formatting

• Basic Formula Creation

• Data Actions

• Cell Reference - Javascript

• Cell Formatting

• File Actions

• Code Snippets

• Open and Use Formula Editor

• Create a Team

• Create Example

• Docs page

• Manage Members

Preexisting bugs

1 Blocking bug

If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

• Intermittent "NaN" Output in Code Modal When Using Queried SQL Data with JavaScript

1 Non-blocking bug

• Cells Evaluate to Error When Running All Code Cells