fix: focus

[AyushAgrawal-A2]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Oct 3, 2024 10:04pm

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (cc8fde0) to head (2622214).
Report is 24 commits behind head on qa.

Additional details and impacted files

@@           Coverage Diff           @@
##               qa    #1945   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         247      247           
  Lines       54593    54593           
=======================================
  Hits        49553    49553           
  Misses       5040     5040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jimniels]

On minor comment, but otherwise LGTM 👍

[jimniels]

Minor, take it or leave it: I don't know if we'll ever have another use for this menu, in which case you could just put this on the underlying MenubarContent shadcn component.

I did that with onEscapeKeyDown so I wouldn't have to put it on every use of the component in the file menu.

[AyushAgrawal-A2]

done

[qa-wolf]

E2E tests

QA 1 blocking bug

Ran	Status	Preview	Started	Run time	Est. dev time saved
74 workflows	Done (Details)		Oct 5, 2024 at 5:09 PM (UTC)	21 minutes	~29.83 hrs

✅ 70 passed

• AI Assistant

• Sheet Actions

• Read Python Output within Formula

• Discard Changes

• Log In

• Dashboard Views - My Files

• Switching Tabs Persists Cursor

• Make Changes while Network is off

• Rename Team

• Can View Members are Unable to Invite Members

• Action Visibility

• API Calls

• Code Editor Displays Return

• Share File - Dashboard

• Text Wrap, Horizontal and Vertical Alignment

• Removed Member No Longer Can Access Team Files

• Open Python Editor

• Basic Formula Creation

• Read JavaScript Output within Formula

• Share File - Spreadsheet

• File Actions

• Connection goes down in Multiplayer Session

• Auto-Complete

• Can Edit Member are Able to Change Permissions

• Formulas

• Can Stop Code Execution

• Create File for Team

• Help Actions

• File Actions - Dashboard

• Cell Formatting

• Can Edit Members are Able to Invite

• Cell Reference - Python

• Zoom Options

• Create a Team

• Custom time and date formatting

• Invite Member to Team

• Create Example

• Create New File

• Data Actions

• Switch between Python and Formula

• Time Formatting

• Can View Team Member Cannot Edit Files

• Drag Relative References

• Date Formatting

• Members Can Leave Team

• Dashboard Views - Shared with me

• Filter Files by Name - Shared with me

• Docs page

• Filter Files by Name - My Files

• Open and Use Formula Editor

• Edit Share File Permissions

• Log Out

• SQL - Reference Data in Formula and Python

• Cell Reference - Javascript

• Formatting

• Manage Members

• Mouse Visibility

• Number Formatting

• Charts

• Import Files

• Resize Column width with Fill

• Can Edit Team Member Can Edit Files

• Right Click Actions

• Code Snippets

• SQL - Create a Connection, Add Data to Database, Query Database

• Types: Series and Data-Frames

• Open Formula Editor

• Upload Large File

• View Actions

• Spills

Preexisting bugs

1 Blocking bug

If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

• Intermittent "NaN" Output in Code Modal When Using Queried SQL Data with JavaScript

1 Non-blocking bug

• Cells Evaluate to Error When Running All Code Cells

. . . . . . . .

Re-run your E2E tests