Insert today's date (shortcut: ctrl+;) #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #1929 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 246 246
Lines 54247 54247
=======================================
Hits 49459 49459
Misses 4788 4788 ☔ View full report in Codecov by Sentry. |
ddimaria
reviewed
Oct 2, 2024
| const sheet = sheets.sheet; | ||
| const cursor = sheet.cursor; | ||
| const today = new Date(); | ||
| const formattedDate = `${today.getFullYear()}/${today.getMonth() + 1}/${today.getDate()}`; |
There was a problem hiding this comment.
It would be nice to have a date utilities file for stuff like this.
ddimaria
reviewed
Oct 2, 2024
| const sheet = sheets.sheet; | ||
| const cursor = sheet.cursor; | ||
| const today = new Date(); | ||
| const formattedDate = `${today.getFullYear()}/${today.getMonth() + 1}/${today.getDate()}`; |
There was a problem hiding this comment.
Same comment here. I've seen this repeat several times, ripe to be refactored into a reusable function.
ddimaria
approved these changes
Oct 2, 2024
|
bonus points if cmd+; does the time |
luke-quadratic
added
status: ready to merge
and removed
status: ready for user test
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inserts today's date when pressing ctrl+; (or via the command palette). This is an Excel shortcut.