Text autocomplete based on column neighbors #1905
Conversation
davidfig
commented
Sep 23, 2024
•
davidfig
commented
- rust search of all text neighbors into a string[]
- when one value is found, show it as selected autocomplete in the inline editor
- when more than one value is found, show it as a dropdown box
- limited neighboring value list to 1,000 entries
- make sure it doesn't conflict with validations
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
davidfig
added
prototype
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## qa #1905 +/- ##
==========================================
+ Coverage 91.16% 91.17% +0.01%
==========================================
Files 246 246
Lines 54161 54247 +86
==========================================
+ Hits 49374 49459 +85
- Misses 4787 4788 +1 ☔ View full report in Codecov by Sentry. |
davidfig
added
status: ready for code review
and removed
prototype
| const validations = sheets.sheet.getValidation(pos.x, pos.y); | ||
| if (validations?.length) { | ||
| const validation = validations[0]; | ||
| if (validationRuleSimple(validation) === 'logical') { |
There was a problem hiding this comment.
Could be converted into a switch statement?
| const dropdownKeyboard = (key: 'ArrowDown' | 'ArrowUp' | 'Enter' | 'Escape' | 'Tab') => { | ||
| if (!filteredList) return; | ||
|
|
||
| if (key === 'ArrowDown' || key === 'ArrowUp') { |
There was a problem hiding this comment.
Another good candidate for a switch statement (might make it more readable/scanable).
| const model = this.getModel(); | ||
| editor.setModelLanguage(model, language); | ||
| this.setBracketConfig(language === 'Formula'); | ||
| if (this.editor) { | ||
| this.editor.updateOptions({ | ||
| quickSuggestions: language === 'Formula' ? true : { other: 'inline' }, |
There was a problem hiding this comment.
Thank you Monaco for an api that accepts an object or a boolean value 🤯
| @@ -111,6 +111,7 @@ export const HtmlValidationList = (props: Props) => { | |||
| // handle keyboard events when list is open | |||
| useEffect(() => { | |||
| const dropdownKeyboard = (key: 'ArrowDown' | 'ArrowUp' | 'ArrowLeft' | 'ArrowRight' | 'Enter' | 'Escape') => { | |||
| debugger; | |||
| @@ -186,6 +188,44 @@ impl Sheet { | |||
| }); | |||
| results | |||
| } | |||
|
|
|||
| /// Returns a Vec<String> of all the neighboring text in the column. Search | |||
| } | ||
| text.push(t.clone()); | ||
| y -= 1; | ||
| } else { |
There was a problem hiding this comment.
You may be able to remove this else block, but that might require the moving of y -= 1 outside of the conditional.
luke-quadratic
added
status: ready to merge
and removed
status: ready for user test
labels
