chore: cleanup clones for upgrade/import/export file for v1.7 #1901
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## borders-rework #1901 +/- ##
==================================================
+ Coverage 90.94% 90.98% +0.03%
==================================================
Files 236 236
Lines 48371 48328 -43
==================================================
- Hits 43991 43970 -21
+ Misses 4380 4358 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AyushAgrawal-A2
changed the title
| Value::Array(crate::Array::from( | ||
| values | ||
| .chunks(size.w as usize) | ||
| .map(|row| row.iter().map(import_cell_value).collect::<Vec<_>>()) | ||
| .map(|row| { | ||
| row.iter() | ||
| .map(|value| import_cell_value(value.to_owned())) | ||
| .collect::<Vec<_>>() | ||
| }) |
There was a problem hiding this comment.
not able to figure out how to get owned value here, row chunk is a slice
value.to_owned() can be avoided if we can directly use owned value
| @@ -79,7 +82,9 @@ pub(crate) fn export_rows_code_runs( | |||
| }, | |||
| values: array | |||
| .rows() | |||
| .flat_map(|row| row.iter().map(export_cell_value)) | |||
| .flat_map(|row| { | |||
| row.iter().map(|value| export_cell_value(value.to_owned())) | |||
There was a problem hiding this comment.
I don't think there's an easy way to avoid this one. It's possible by collecting each row into a Vec<()> before transforming it, or by just manually building up a Vec<Vec<()>> element-by-element in this function. The latter is the most clone-free way but it's not pretty.
No description provided.