Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app redesign #1833

Merged
merged 139 commits into from
Sep 20, 2024
Merged

feat: app redesign #1833

merged 139 commits into from
Sep 20, 2024

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented Sep 3, 2024

Feature

Todos

  • Sidebar with actions
  • File menu with actions (needs to be wired up)
  • Formatting bar with actions (needs to be wired up)
  • Get rid of floating context menu and have a right-click context menu
  • Command palette actions/icons
    • Not all of these got wired up, we'll do this slowly over time
  • Permissions
  • Mixpanel events for new menus
    • Formatting bar
    • File menus
    • Sidebar
  • Responsiveness
  • Fix all TODO: (jimniels) in PR code
  • Map app/ui/icons to shared/components/icons
    • app/ui/icons were marked as deprecated and we'll slowly replace these over time

Nice to haves

  • User menu in upper right (sign out)
  • Swap out icons on dashboard to new ones

Didn't Do

  • Formatting button renders real-time update depending on the active formatting applied to the current cell

Outstanding Bugs

  • Clicking on code editor in the side bar with a newly opened file doesn't properly set the location. And code is lost after running and closing.
  • User primary color for resize controls
  • Show sidebar on tablet
  • Kernel menu not opening
  • Hot-swapping code cells doesn't work
  • Code peak triggers when menus are open (@davidfig)
  • Avatars don't align in sheet for multiplayer situations (img)

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Sep 20, 2024 4:33pm

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
Copy link

qa-wolf bot commented Sep 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1833 September 3, 2024 17:35 Inactive
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (cc112f5) to head (65659c4).
Report is 140 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1833   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         220      220           
  Lines       46072    46072           
=======================================
  Hits        41902    41902           
  Misses       4170     4170           
Flag Coverage Δ
90.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 4, 2024 17:43 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 4, 2024 23:15 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 5, 2024 15:25 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 5, 2024 15:39 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 19:59 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 22:03 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 22:18 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 22:28 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 23:14 Inactive
package.json Outdated Show resolved Hide resolved
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1833 September 19, 2024 23:49 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1833 September 20, 2024 16:16 Inactive
@davidkircos davidkircos merged commit e311adf into qa Sep 20, 2024
16 checks passed
@davidkircos davidkircos deleted the redesign branch September 20, 2024 16:51
Copy link

qa-wolf bot commented Sep 20, 2024

E2E tests

Ran Status Preview Started
74 workflows In review (Details) Sep 20, 2024 at 5:22 PM (UTC)
⚠️ 47 failed - your wolf pack is investigating
✅ 23 passed

Preexisting bugs

0 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants