Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more restrictive IAM policy #95

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Use more restrictive IAM policy #95

merged 2 commits into from
Jan 3, 2024

Conversation

vmercierfr
Copy link
Collaborator

Objective

Use more restrictive IAM policy

Why

Help AWS users to audit and adjust IAM permissions to enable features.

For instance, it will be easier for users who don't collect log information (collect-logs-size=false) to remove unnecessary IAM permissions.

Today, we don't specify parameters to collect AWS RDS maintenances, so we can't limit resource for rds:DescribePendingMaintenanceActions action, but we may support in the future.

How

  • Update IAM policies
  • Fix typo in README

Release plan

  • Merge this PR

@vmercierfr vmercierfr added the documentation Improvements or additions to documentation label Dec 20, 2023
@vmercierfr vmercierfr self-assigned this Dec 20, 2023
@vmercierfr
Copy link
Collaborator Author

I created #96 to fix the issue with rds:DescribePendingMaintenanceActions IAM permission

@vmercierfr
Copy link
Collaborator Author

#sre

@vmercierfr
Copy link
Collaborator Author

For Qonto's review: The policy is successfully deployed in our different AWS accounts.

@vmercierfr
Copy link
Collaborator Author

#sre

Copy link
Contributor

@dcupif dcupif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
@vmercierfr vmercierfr merged commit 2260379 into main Jan 3, 2024
7 of 8 checks passed
@vmercierfr vmercierfr deleted the fix-iam-policy branch January 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants