Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with SymbolicUtils and TermInterface v2 #212

Closed
wants to merge 8 commits into from
Closed

compat with SymbolicUtils and TermInterface v2 #212

wants to merge 8 commits into from

Conversation

oameye
Copy link
Contributor

@oameye oameye commented Jul 21, 2024

After this is merged all the compathelper PR can be closed
image
Relevant:

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (8719ab5) to head (c65acc0).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   78.63%   78.72%   +0.09%     
==========================================
  Files          26       26              
  Lines        5379     5383       +4     
==========================================
+ Hits         4230     4238       +8     
+ Misses       1149     1145       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oameye oameye marked this pull request as draft July 21, 2024 11:21
@oameye oameye changed the title bump compat TermInterface to v2 and fix deprecation warning compat with SymbolicUtils and TermInterface v2 Jul 21, 2024
@oameye oameye marked this pull request as ready for review August 7, 2024 19:29
@david-pl david-pl mentioned this pull request Aug 20, 2024
@david-pl
Copy link
Member

@oameye finally merged the other PR, so closing this one.

@david-pl david-pl closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants