Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft CI/CD #2

Merged
merged 16 commits into from
May 8, 2024
Merged

draft CI/CD #2

merged 16 commits into from
May 8, 2024

Conversation

sebastroy
Copy link
Collaborator

No description provided.

@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch from 59d0492 to 45ba9eb Compare May 6, 2024 12:33
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch 16 times, most recently from 3483f86 to c6ab274 Compare May 6, 2024 15:38
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch from c6ab274 to dab4d85 Compare May 6, 2024 15:41
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch from 4f12339 to 22c4271 Compare May 6, 2024 19:43
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch from 22c4271 to 2425f56 Compare May 6, 2024 19:45
Copy link

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question on my end

.github/actions/test/action.yml Outdated Show resolved Hide resolved
.github/actions/bumpversion/action.yml Outdated Show resolved Hide resolved
.github/actions/test/action.yml Outdated Show resolved Hide resolved
.github/actions/upload-wheel/action.yml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch 3 times, most recently from 0624f40 to 4064f21 Compare May 8, 2024 15:38
@sebastroy sebastroy force-pushed the feature/ci-cd-gemfury branch from 4064f21 to 87beb3d Compare May 8, 2024 15:39
shell: bash
- name: Test with pytest
run: |
echo pytest tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are using echo here?

- name: Build and install our repo
uses: ./.github/actions/python-build
- name: Push version
uses: ./.github/actions/pushversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you committed this file?

@sebastroy sebastroy merged commit f6fa330 into develop May 8, 2024
1 check passed
@jamesETsmith jamesETsmith deleted the feature/ci-cd-gemfury branch May 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants