Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pauli string cpp #9

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Feature/pauli string cpp #9

merged 10 commits into from
Jul 26, 2024

Conversation

stand-by
Copy link
Collaborator

Initial python bindings and other cpp and cmake related changes

Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions so far, everything looks good. Now let's get some tests using the python wrappers (which I think you've already started on)

fast_pauli/cpp/include/__pauli_string.hpp Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/CMakeLists.txt Outdated Show resolved Hide resolved
fast_pauli/cpp/src/CMakeLists.txt Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments

README.md Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__pauli_string.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @stand-by!

@stand-by stand-by merged commit 6f4940a into develop Jul 26, 2024
3 checks passed
@jamesETsmith jamesETsmith deleted the feature/pauli_string_cpp branch July 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants