Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fast pauli docstrings #54

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Feature/fast pauli docstrings #54

merged 11 commits into from
Oct 5, 2024

Conversation

stand-by
Copy link
Collaborator

@stand-by stand-by commented Oct 3, 2024 •
edited
Loading

Docstrings for fast_pauli python bindings

sebastroy
sebastroy requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@sebastroy sebastroy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm. Returns plural is the correct one

alexanderlerner
alexanderlerner reviewed Oct 4, 2024
View reviewed changes
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
jamesETsmith
jamesETsmith requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are comments for Pauli and PauliString. Looking at PauliOp next and then I'll check the rendering by building the docs locally

fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
jamesETsmith
jamesETsmith requested changes Oct 4, 2024
View reviewed changes
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
@jamesETsmith jamesETsmith added the documentation Improvements or additions to documentation label Oct 4, 2024
sebastroy
sebastroy previously approved these changes Oct 4, 2024
View reviewed changes
sebastroy
sebastroy previously approved these changes Oct 4, 2024
View reviewed changes
@jamesETsmith jamesETsmith merged commit 8aa395e into main Oct 5, 2024
10 checks passed
@jamesETsmith jamesETsmith deleted the feature/fast-pauli-docstrings branch October 5, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderlerner alexanderlerner alexanderlerner left review comments

@jamesETsmith jamesETsmith jamesETsmith approved these changes

@sebastroy sebastroy sebastroy left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stand-by @jamesETsmith @sebastroy @alexanderlerner