Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pauli string benchmark #11

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Feature/pauli string benchmark #11

merged 5 commits into from
Aug 6, 2024

Conversation

stand-by
Copy link
Collaborator

Draft benchmarking for py vs cpp

jamesETsmith
jamesETsmith requested changes Aug 1, 2024
View reviewed changes
fast_pauli/cpp/src/fast_pauli.cpp Show resolved Hide resolved
benchmarks/test_pauli_string_benchmark.py Outdated Show resolved Hide resolved
benchmarks/test_pauli_string_benchmark.py Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
benchmarks/test_pauli_string_benchmark.py Outdated Show resolved Hide resolved
@stand-by
Copy link
Collaborator Author

stand-by commented Aug 2, 2024

pytest-benchmark allows us to compare new benchmark run against past ones stored in a file. The suggestion is to have a separate makefile command for a dev to compare current code against committed stats to make sure new changes don't introduce any performance degradation. Especially, given that currently people have same hardware across the team. According to their docs we can even make it fail in case time is worse than it used to be. Pls let me know your thoughts, I'll arrange this into asana ticket if people think it's something reasonable to have in a future.

jamesETsmith
jamesETsmith requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just some problems with one of the benchmarks

benchmarks/test_pauli_string_benchmark.py Show resolved Hide resolved
benchmarks/test_pauli_string_benchmark.py Show resolved Hide resolved
@stand-by stand-by force-pushed the feature/pauli_string_benchmark branch from de115a9 to a5ab3ce Compare August 5, 2024 17:48
@stand-by stand-by merged commit f363a96 into develop Aug 6, 2024
3 checks passed
@stand-by stand-by deleted the feature/pauli_string_benchmark branch August 6, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesETsmith jamesETsmith jamesETsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stand-by @jamesETsmith