Skip to content

Commit

Permalink
[feature/setuptools_cmake] Problems with rebuild and scikit-build, pr…
Browse files Browse the repository at this point in the history
…einstalling some dependencies in CI
  • Loading branch information
jamesETsmith committed Oct 1, 2024
1 parent f8af067 commit ed9c731
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/all_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
- name: Install
run: |
cmake --install ${{github.workspace}}/build
python -m pip install "scikit-build-core"
python -m pip install ".[dev]" --no-build-isolation
- name: Test C++
env:
Expand Down
10 changes: 9 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,19 @@
# BUILD
###############################################################################

# Build the C++/Python package will try to reuse existing build directory
# Build the C++/Python package from scratch (ignore existing build dir)
.PHONY: build
build:
python -m pip install -e ".[dev]"

# Build the C++/Python package will try to reuse existing build directory, will
# not always work on a fresh checkout bc it requires prereqs to be installed.
# See https://scikit-build-core.readthedocs.io/en/latest/configuration.html#editable-installs
.PHONY: rebuild
rebuild:
python -m pip install -e ".[dev]" --no-build-isolation


###############################################################################
# DOCS
###############################################################################
Expand Down

0 comments on commit ed9c731

Please sign in to comment.