Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of OK-1 #24646

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Addition of OK-1 #24646

wants to merge 9 commits into from
+446 −0

Conversation

Cipulot
Copy link
Contributor

@Cipulot Cipulot commented Nov 27, 2024 •
edited
Loading

Description

Addition of the OK-1, a low profile switch keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Cipulot Cipulot mentioned this pull request Nov 27, 2024
Open
4 tasks
zvecr
zvecr requested changes Nov 27, 2024
View reviewed changes
keyboards/cipulot/ok_1/config.h Outdated Show resolved Hide resolved
keyboards/cipulot/ok_1/keyboard.json Show resolved Hide resolved
keyboards/cipulot/ok_1/keyboard.json Outdated Show resolved Hide resolved
keyboards/cipulot/ok_1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cipulot/ok_1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cipulot/ok_1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cipulot/ok_1/keymaps/default/keymap.c Show resolved Hide resolved
Cipulot and others added 7 commits November 27, 2024 16:33
@Cipulot
Copy link
Contributor Author

Cipulot commented Nov 27, 2024

@zvecr thank you for the suggestions, applied as suggested.

@Cipulot
Copy link
Contributor Author

Cipulot commented Nov 27, 2024

Updated the RGB keycodes to reflect the changes brought up by RGB Keycode Overhaul changes

@Cipulot Cipulot requested a review from zvecr November 27, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cipulot @zvecr